Add support for CodeStar CodeBuild clone ref and update CodeStar setup #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** The CodeStar provider did not support the `CODEBUILD_CLONE_REF` artifact mode yet. This is useful if you would like to access the git repository, for example to analyze the history or checkout a different branch. For CodeStar Connections, it was trying to resolve the CodeStar Connection Arn from SSM Parameter Store at the pipeline stack generation. However, resolving parameters should be performed in the input generation step. **What?** * Added support to define the `output_artifact_format` in the CodeStar source provider. Allowing `CODEBUILD_CLONE_REF` to be defined as the output format. * Moved resolving the `codestar_connection_path` in SSM Parameter Store to the pipeline input generation. As this is where it should be performed. The Lambda function resolving these parameters has the required permissions already. * Added support for our CloudFormation role to perform `codestar-connections:PassConnection`, such that CodeStar connections can be configured in the CodePipeline stack that it generates.
sbkok
force-pushed
the
feat/code-star-with-full-clone
branch
from
60f2548 to
b116439
Compare
javydekoning
approved these changes
Dec 9, 2022
|
Is this a regression, I feel like this was already added? |
StewartW
approved these changes
Dec 9, 2022
|
It was added for CodeCommit, not for CodeStar apparently. This surprised me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The CodeStar provider did not support the
CODEBUILD_CLONE_REFartifact mode yet. This is useful if you would like to access the git repository, for example to analyze the history or checkout a different branch.For CodeStar Connections, it was trying to resolve the CodeStar Connection Arn from SSM Parameter Store at the pipeline stack generation. However, resolving parameters should be performed in the input generation step.
What?
output_artifact_formatin the CodeStar source provider. AllowingCODEBUILD_CLONE_REFto be defined as the output format.codestar_connection_pathin SSM Parameter Store to the pipeline input generation. As this is where it should be performed. The Lambda function resolving these parameters has the required permissions already.codestar-connections:PassConnection, such that CodeStar connections can be configured in the CodePipeline stack that it generates.By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.